-
-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verify Gifs Filename Linter #366
Verify Gifs Filename Linter #366
Conversation
Codecov Report
@@ Coverage Diff @@
## master #366 +/- ##
=======================================
Coverage 16.91% 16.91%
=======================================
Files 20 20
Lines 1129 1129
Branches 152 152
=======================================
Hits 191 191
Misses 929 929
Partials 9 9 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@tonybaloney this PR should be ready. 😃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The check is running backward. instead of looking at each file and checking if it matches the pattern, it should look at every pet and work out what GIFs should exist and then check they do.
It should go to
- Get all pets
- For each pet get all colors
- For each pet get all possible states by traversing tree
Then check every file exists.
Thanks
I have not done anything to the main-bundle but it has changed in the git diff. |
Thanks, ideally it should import those types and do it dynamically but we can tackle that later |
Verify Gifs Filename Linter
A linter that runs a test which tests if gifs follow the pattern. For #363